Commit 32157de2 authored May 05, 2016 by Jens Axboe Committed by Theodore Ts'o May 05, 2016

ext4: remove unnecessary bio get/put



ext4_io_submit() used to check for EOPNOTSUPP after bio submission,
which is why it had to get an extra reference to the bio before
submitting it. But since we no longer touch the bio after submission,
get rid of the redundant get/put of the bio. If we do get the extra
reference, we enter the slower path of having to flag this bio as now
having external references.

Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 935244cd

fs/ext4/page-io.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -342,9 +342,7 @@ void ext4_io_submit(struct ext4_io_submit *io)
		if (bio) {
		int io_op = io->io_wbc->sync_mode == WB_SYNC_ALL ?
		WRITE_SYNC : WRITE;
		bio_get(io->io_bio);
		submit_bio(io_op, io->io_bio);
		bio_put(io->io_bio);
		}
		io->io_bio = NULL;
		}

Admin message