Commit 321238fb authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: Fix ext4_should_journal_data() for EA inodes 



Similarly to directories, EA inodes do only journalled modifications to
their data. Change ext4_should_journal_data() to return true for them so
that we don't have to special-case them during truncate.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-7-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 65db869c

fs/ext4/ext4_jbd2.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -407,6 +407,7 @@ static inline int ext4_inode_journal_mode(struct inode *inode) 
		return EXT4_INODE_WRITEBACK_DATA_MODE;	/* writeback */

		return EXT4_INODE_WRITEBACK_DATA_MODE;	/* writeback */

	/* We do not support data journalling with delayed allocation */

	/* We do not support data journalling with delayed allocation */

	if (!S_ISREG(inode->i_mode) ||

	if (!S_ISREG(inode->i_mode) ||

	    ext4_test_inode_flag(inode, EXT4_INODE_EA_INODE) ||

	    test_opt(inode->i_sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA ||

	    test_opt(inode->i_sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA ||

	    (ext4_test_inode_flag(inode, EXT4_INODE_JOURNAL_DATA) &&

	    (ext4_test_inode_flag(inode, EXT4_INODE_JOURNAL_DATA) &&

	    !test_opt(inode->i_sb, DELALLOC))) {

	    !test_opt(inode->i_sb, DELALLOC))) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE