Commit 31efee60 authored Dec 27, 2012 by Jeff Layton Committed by Steve French Dec 30, 2012

cifs: adjust sequence number downward after signing NT_CANCEL request



When a call goes out, the signing code adjusts the sequence number
upward by two to account for the request and the response. An NT_CANCEL
however doesn't get a response of its own, it just hurries the server
along to get it to respond to the original request more quickly.
Therefore, we must adjust the sequence number back down by one after
signing a NT_CANCEL request.

Cc: <stable@vger.kernel.org>
Reported-by: Tim Perry <tdparmor-sambabugs@yahoo.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>

parent ea702b80

fs/cifs/smb1ops.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -53,6 +53,13 @@ send_nt_cancel(struct TCP_Server_Info server, void buf,
		mutex_unlock(&server->srv_mutex);
		return rc;
		}

		/*
		* The response to this call was already factored into the sequence
		* number when the call went out, so we must adjust it back downward
		* after signing here.
		*/
		--server->sequence_number;
		rc = smb_send(server, in_buf, be32_to_cpu(in_buf->smb_buf_length));
		mutex_unlock(&server->srv_mutex);

Admin message