Commit 31d4c528 authored Mar 27, 2019 by Vincent Stehlé Committed by Rafael J. Wysocki Mar 28, 2019

cpufreq: scpi: Fix use after free



Free the priv structure only after we are done using it.

Fixes: 1690d8bb ("cpufreq: scpi/scmi: Fix freeing of dynamic OPPs")
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: 4.20+ <stable@vger.kernel.org> # 4.20+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 92a3e426

drivers/cpufreq/scpi-cpufreq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -189,8 +189,8 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy)

		clk_put(priv->clk);
		dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);
		kfree(priv);
		dev_pm_opp_remove_all_dynamic(priv->cpu_dev);
		kfree(priv);

		return 0;
		}

Admin message