Commit 31d2350d authored Feb 18, 2019 by Takashi Iwai

ALSA: ac97: Fix of-node refcount unbalance



ac97_of_get_child_device() take the refcount of the node explicitly
via of_node_get(), but this leads to an unbalance.  The
for_each_child_of_node() loop itself takes the refcount for each
iteration node, hence you don't need to take the extra refcount
again.

Fixes: 2225a3e6 ("ALSA: ac97: add codecs devicetree binding")
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent c7a13264

sound/ac97/bus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,7 @@ ac97_of_get_child_device(struct ac97_controller *ac97_ctrl, int idx,
		if ((idx != of_property_read_u32(node, "reg", &reg)) \|\|
		!of_device_is_compatible(node, compat))
		continue;
		return of_node_get(node);
		return node;
		}

		return NULL;

Admin message