crypto: md4 - Use ARRAY_SIZE (31a61bfc) · Commits · 戴 / test

ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type or the size of its first element. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/ ) // <smpl> @i@ @@ #include <linux/kernel.h> @depends on i using "paren.iso"@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) // </smpl> Signed-off-by:

Julia Lawall <julia@diku.dk> Signed-off-by:

Herbert Xu <herbert@gondor.apana.org.au>

crypto/md4.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -148,7 +148,7 @@ static void md4_transform(u32 hash, u32 const in)

		static inline void md4_transform_helper(struct md4_ctx *ctx)
		{
		le32_to_cpu_array(ctx->block, sizeof(ctx->block) / sizeof(u32));
		le32_to_cpu_array(ctx->block, ARRAY_SIZE(ctx->block));
		md4_transform(ctx->hash, ctx->block);
		}

		@@ -214,7 +214,7 @@ static void md4_final(struct crypto_tfm tfm, u8 out)
		le32_to_cpu_array(mctx->block, (sizeof(mctx->block) -
		sizeof(u64)) / sizeof(u32));
		md4_transform(mctx->hash, mctx->block);
		cpu_to_le32_array(mctx->hash, sizeof(mctx->hash) / sizeof(u32));
		cpu_to_le32_array(mctx->hash, ARRAY_SIZE(mctx->hash));
		memcpy(out, mctx->hash, sizeof(mctx->hash));
		memset(mctx, 0, sizeof(*mctx));
		}

Admin message