Commit 319b11ef authored Jun 21, 2018 by Wesley W. Terpstra Committed by Greg Kroah-Hartman Jul 07, 2018

base: fix order of OF initialization



This fixes: [    0.010000] cpu cpu0: Error -2 creating of_node link
... which you get for every CPU on all architectures that use
CONFIG_GENERIC_CPU_DEVICES.

In that case, driver_init() calls cpu_dev_init() before calling
of_core_init(). Then we get the callchain:

  cpu_dev_init()
    -> cpu_dev_register_generic()
    -> register_cpu(cpu, i)
    -> device_register(&cpu->dev)
    -> device_add(dev)
    -> device_add_class_symlinks(dev)

... in device_add_class_symlinks, we we dev->of_node, and call
sysfs_create_link(), which fails because we haven't called
of_core_init() to register the sysfs devicetree directory yet.

Signed-off-by: Wesley W. Terpstra <wesley@sifive.com>
[hch: updated the changelog based on review feedback]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ea614629

drivers/base/init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -30,9 +30,9 @@ void __init driver_init(void)
		/* These are also core pieces, but must come after the
		* core core pieces.
		*/
		of_core_init();
		platform_bus_init();
		cpu_dev_init();
		memory_dev_init();
		container_dev_init();
		of_core_init();
		}

Admin message