Commit 3194ed49 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix possible race on regmap bypass flip 

HD-audio driver uses regmap cache bypass feature for reading a raw
value without the cache.  But this is racy since both the cached and
the uncached reads may occur concurrently.  The former is done via the
normal control API access while the latter comes from the proc file
read.

Even though the regmap itself has the protection against the
concurrent accesses, the flag set/reset is done without the
protection, so it may lead to inconsistent state of bypass flag that
doesn't match with the current read and occasionally result in a
kernel WARNING like:
  WARNING: CPU: 3 PID: 2731 at drivers/base/regmap/regcache.c:499 regcache_cache_only+0x78/0x93

One way to work around such a problem is to wrap with a mutex.  But in
this case, the solution is simpler: for the uncached read, we just
skip the regmap and directly calls its accessor.  The verb execution
there is protected by itself, so basically it's safe to call
individually.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116171


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 67f3754b

include/sound/hda_regmap.h

+2 −0
Original line number Diff line number Diff line
@@ -17,6 +17,8 @@ int snd_hdac_regmap_add_vendor_verb(struct hdac_device *codec, 
				    unsigned int verb);

int snd_hdac_regmap_read_raw(struct hdac_device *codec, unsigned int reg,

			     unsigned int *val);

int snd_hdac_regmap_read_raw_uncached(struct hdac_device *codec,

				      unsigned int reg, unsigned int *val);

int snd_hdac_regmap_write_raw(struct hdac_device *codec, unsigned int reg,

			      unsigned int val);

int snd_hdac_regmap_update_raw(struct hdac_device *codec, unsigned int reg,

sound/hda/hdac_device.c

+4 −6
Original line number Diff line number Diff line
@@ -299,13 +299,11 @@ EXPORT_SYMBOL_GPL(_snd_hdac_read_parm); 
int snd_hdac_read_parm_uncached(struct hdac_device *codec, hda_nid_t nid,

				int parm)

{

	int val;

	unsigned int cmd, val;



	if (codec->regmap)

		regcache_cache_bypass(codec->regmap, true);

	val = snd_hdac_read_parm(codec, nid, parm);

	if (codec->regmap)

		regcache_cache_bypass(codec->regmap, false);

	cmd = snd_hdac_regmap_encode_verb(nid, AC_VERB_PARAMETERS) | parm;

	if (snd_hdac_regmap_read_raw_uncached(codec, cmd, &val) < 0)

		return -1;

	return val;

}

EXPORT_SYMBOL_GPL(snd_hdac_read_parm_uncached);

sound/hda/hdac_regmap.c

+28 −12
Original line number Diff line number Diff line
@@ -453,14 +453,30 @@ int snd_hdac_regmap_write_raw(struct hdac_device *codec, unsigned int reg, 
EXPORT_SYMBOL_GPL(snd_hdac_regmap_write_raw);



static int reg_raw_read(struct hdac_device *codec, unsigned int reg,

			unsigned int *val)

			unsigned int *val, bool uncached)

{

	if (!codec->regmap)

	if (uncached || !codec->regmap)

		return hda_reg_read(codec, reg, val);

	else

		return regmap_read(codec->regmap, reg, val);

}



static int __snd_hdac_regmap_read_raw(struct hdac_device *codec,

				      unsigned int reg, unsigned int *val,

				      bool uncached)

{

	int err;



	err = reg_raw_read(codec, reg, val, uncached);

	if (err == -EAGAIN) {

		err = snd_hdac_power_up_pm(codec);

		if (!err)

			err = reg_raw_read(codec, reg, val, uncached);

		snd_hdac_power_down_pm(codec);

	}

	return err;

}



/**

 * snd_hdac_regmap_read_raw - read a pseudo register with power mgmt

 * @codec: the codec object
@@ -472,19 +488,19 @@ static int reg_raw_read(struct hdac_device *codec, unsigned int reg, 
int snd_hdac_regmap_read_raw(struct hdac_device *codec, unsigned int reg,

			     unsigned int *val)

{

	int err;



	err = reg_raw_read(codec, reg, val);

	if (err == -EAGAIN) {

		err = snd_hdac_power_up_pm(codec);

		if (!err)

			err = reg_raw_read(codec, reg, val);

		snd_hdac_power_down_pm(codec);

	}

	return err;

	return __snd_hdac_regmap_read_raw(codec, reg, val, false);

}

EXPORT_SYMBOL_GPL(snd_hdac_regmap_read_raw);



/* Works like snd_hdac_regmap_read_raw(), but this doesn't read from the

 * cache but always via hda verbs.

 */

int snd_hdac_regmap_read_raw_uncached(struct hdac_device *codec,

				      unsigned int reg, unsigned int *val)

{

	return __snd_hdac_regmap_read_raw(codec, reg, val, true);

}



/**

 * snd_hdac_regmap_update_raw - update a pseudo register with power mgmt

 * @codec: the codec object

CRA Git | Maintained and supported by SUSTech CRA and CCSE