Commit 3175bd9a authored Oct 28, 2011 by Allan Stephens Committed by Paul Gortmaker Feb 06, 2012

tipc: Eliminate alteration of publication key during name table purging



Removes code that alters the publication key of a name table entry
that is being forcibly purged from TIPC's name table after contact
with the publishing node has been lost.

Current TIPC ensures that all defunct names are purged before
re-establishing contact with a failed node.  There used to be a risk
that the publication might be accidentally deleted because it might be
re-added to the name table before the purge operation was completed.
But now there is no longer a need to ensure that the new key is different
than the old one.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

parent 63e7f1ac

net/tipc/name_distr.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -239,9 +239,6 @@ exit:
		*
		* Invoked for each publication issued by a newly failed node.
		* Removes publication structure from name table & deletes it.
		* In rare cases the link may have come back up again when this
		* function is called, and we have two items representing the same
		* publication. Nudge this item's key to distinguish it from the other.
		*/

		static void named_purge_publ(struct publication *publ)
		@@ -249,7 +246,6 @@ static void named_purge_publ(struct publication *publ)
		struct publication *p;

		write_lock_bh(&tipc_nametbl_lock);
		publ->key += 1222345;
		p = tipc_nametbl_remove_publ(publ->type, publ->lower,
		publ->node, publ->ref, publ->key);
		if (p)

Admin message