Commit 317168d0 authored Oct 28, 2014 by Takashi Iwai

ALSA: pcm: Zero-clear reserved fields of PCM status ioctl in compat mode



In compat mode, we copy each field of snd_pcm_status struct but don't
touch the reserved fields, and this leaves uninitialized values
there.  Meanwhile the native ioctl does zero-clear the whole
structure, so we should follow the same rule in compat mode, too.

Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent d1d0b6b6

sound/core/pcm_compat.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -210,6 +210,8 @@ static int snd_pcm_status_user_compat(struct snd_pcm_substream *substream,
		if (err < 0)
		return err;

		if (clear_user(src, sizeof(*src)))
		return -EFAULT;
		if (put_user(status.state, &src->state) \|\|
		compat_put_timespec(&status.trigger_tstamp, &src->trigger_tstamp) \|\|
		compat_put_timespec(&status.tstamp, &src->tstamp) \|\|

Admin message