Commit 315917d2 authored Nov 29, 2006 by Francois Romieu Committed by Linus Torvalds Nov 29, 2006

[PATCH] r8169: Fix iteration variable sign



This changes the type of variable "i" in rtl8169_init_one()
from "unsigned int" to "int". "i" is checked for < 0 later,
which can never happen for "unsigned". This results in broken
error handling.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent af768c67

drivers/net/r8169.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1473,8 +1473,8 @@ rtl8169_init_one(struct pci_dev pdev, const struct pci_device_id ent)
		struct rtl8169_private *tp;
		struct net_device *dev;
		void __iomem *ioaddr;
		unsigned int i, pm_cap;
		int rc;
		unsigned int pm_cap;
		int i, rc;

		if (netif_msg_drv(&debug)) {
		printk(KERN_INFO "%s Gigabit Ethernet driver %s loaded\n",

Admin message