Commit 3144533b authored Sep 26, 2018 by Dennis Dalessandro Committed by Jason Gunthorpe Sep 30, 2018

IB/hfi1: Ensure ucast_dlid access doesnt exceed bounds



The dlid assignment made by looking into the u_ucast_dlid array does not
do an explicit check for the size of the array. The code path to arrive at
def_port, the index value is long and complicated so its best to just have
an explicit check here.

Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 15b796bc

drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -351,6 +351,7 @@ static uint32_t opa_vnic_get_dlid(struct opa_vnic_adapter *adapter,
		if (unlikely(!dlid))
		v_warn("Null dlid in MAC address\n");
		} else if (def_port != OPA_VNIC_INVALID_PORT) {
		if (def_port < OPA_VESW_MAX_NUM_DEF_PORT)
		dlid = info->vesw.u_ucast_dlid[def_port];
		}
		}

Admin message