Commit 31358063 authored Jan 14, 2006 by Valdis.Kletnieks@vt.edu Committed by Linus Torvalds Jan 14, 2006

[PATCH] quota: make useless quota error message informative



fs/quota_v2.c can, under some conditions, issue a kernel message that says,
in totality, 'failed read'.  This patch does the following:

1) Gives a hint who issued the error message, so people reading the logs
   don't have to go grepping the entire kernel tree (with 11 false
   positives).

2) Say what amount of data we expected, and actually got.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Jan Kara <jack@ucw.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent d9975d6b

fs/quota_v2.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -35,7 +35,8 @@ static int v2_check_quota_file(struct super_block *sb, int type)

		size = sb->s_op->quota_read(sb, type, (char *)&dqhead, sizeof(struct v2_disk_dqheader), 0);
		if (size != sizeof(struct v2_disk_dqheader)) {
		printk("failed read\n");
		printk("quota_v2: failed read expected=%d got=%d\n",
		sizeof(struct v2_disk_dqheader), size);
		return 0;
		}
		if (le32_to_cpu(dqhead.dqh_magic) != quota_magics[type] \|\|

Admin message