Commit 3122e80e authored Apr 06, 2020 by Anshuman Khandual Committed by Linus Torvalds Apr 07, 2020

mm/vma: make vma_is_accessible() available for general use



Lets move vma_is_accessible() helper to include/linux/mm.h which makes it
available for general use.  While here, this replaces all remaining open
encodings for VMA access check with vma_is_accessible().

Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Guo Ren <guoren@kernel.org>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Guo Ren <guoren@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Nick Piggin <npiggin@gmail.com>
Cc: Paul Mackerras <paulus@ozlabs.org>
Cc: Will Deacon <will@kernel.org>
Link: http://lkml.kernel.org/r/1582520593-30704-3-git-send-email-anshuman.khandual@arm.com


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7e96fb57

arch/csky/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -141,7 +141,7 @@ good_area:
		if (!(vma->vm_flags & VM_WRITE))
		goto bad_area;
		} else {
		if (!(vma->vm_flags & (VM_READ \| VM_WRITE \| VM_EXEC)))
		if (!vma_is_accessible(vma))
		goto bad_area;
		}

arch/m68k/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -125,7 +125,7 @@ good_area:
		case 1: /* read, present */
		goto acc_err;
		case 0: /* read, not present */
		if (!(vma->vm_flags & (VM_READ \| VM_EXEC \| VM_WRITE)))
		if (!vma_is_accessible(vma))
		goto acc_err;
		}

arch/mips/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -142,7 +142,7 @@ good_area:
		goto bad_area;
		}
		} else {
		if (!(vma->vm_flags & (VM_READ \| VM_WRITE \| VM_EXEC)))
		if (!vma_is_accessible(vma))
		goto bad_area;
		}
		}

arch/powerpc/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -314,7 +314,7 @@ static bool access_error(bool is_write, bool is_exec,
		return false;
		}

		if (unlikely(!(vma->vm_flags & (VM_READ \| VM_EXEC \| VM_WRITE))))
		if (unlikely(!vma_is_accessible(vma)))
		return true;
		/*
		* We should ideally do the vma pkey access check here. But in the

arch/sh/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -355,7 +355,7 @@ static inline int access_error(int error_code, struct vm_area_struct *vma)
		return 1;

		/* read, not present: */
		if (unlikely(!(vma->vm_flags & (VM_READ \| VM_EXEC \| VM_WRITE))))
		if (unlikely(!vma_is_accessible(vma)))
		return 1;

		return 0;

Admin message