Commit 310b30e5 authored by Christoph Hellwig's avatar Christoph Hellwig
Browse files

nvme: remove the 0 lba_shift check in nvme_update_ns_info 



We can no longer reach this code if Identify Namespace failed.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
parent 13f0b26b

drivers/nvme/host/core.c

+0 −6
Original line number Diff line number Diff line
@@ -2129,13 +2129,7 @@ static int nvme_update_ns_info(struct nvme_ns *ns, struct nvme_id_ns *id) 
	int ret;



	blk_mq_freeze_queue(ns->disk->queue);

	/*

	 * If identify namespace failed, use default 512 byte block size so

	 * block layer can use before failing read/write for 0 capacity.

	 */

	ns->lba_shift = id->lbaf[lbaf].ds;

	if (ns->lba_shift == 0)

		ns->lba_shift = 9;



	switch (ns->head->ids.csi) {

	case NVME_CSI_NVM:

CRA Git | Maintained and supported by SUSTech CRA and CCSE