Commit 30e73671 authored Mar 26, 2020 by Saurav Kashyap Committed by Martin K. Petersen Mar 29, 2020

scsi: bnx2fc: Fix SCSI command completion after cleanup is posted

Driver received a SCSI completion after it posted the cleanup request. This
leads to a problem that one ref count wasn't released leading to
flush_active_ios to get struck. The callback from libfc never returned and
other ports were not processed leading to APD.

Decrease the refcnt as well as try to complete if something is waiting for
completion.

Link: https://lore.kernel.org/r/20200327054849.15947-3-skashyap@marvell.com


Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 77331115

drivers/scsi/bnx2fc/bnx2fc_io.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1917,6 +1917,12 @@ void bnx2fc_process_scsi_cmd_compl(struct bnx2fc_cmd *io_req,
		/* we will not receive ABTS response for this IO */
		BNX2FC_IO_DBG(io_req, "Timer context finished processing "
		"this scsi cmd\n");
		if (test_and_clear_bit(BNX2FC_FLAG_IO_CLEANUP,
		&io_req->req_flags)) {
		BNX2FC_IO_DBG(io_req,
		"Actual completion after cleanup request cleaning up\n");
		bnx2fc_process_cleanup_compl(io_req, task, num_rq);
		}
		return;
		}

Admin message