Commit 30d97754 authored by Andrew Murray's avatar Andrew Murray Committed by Marc Zyngier
Browse files

KVM: arm/arm64: Re-create event when setting counter value 



The perf event sample_period is currently set based upon the current
counter value, when PMXEVTYPER is written to and the perf event is created.
However the user may choose to write the type before the counter value in
which case sample_period will be set incorrectly. Let's instead decouple
event creation from PMXEVTYPER and (re)create the event in either
suitation.

Signed-off-by: default avatarAndrew Murray <andrew.murray@arm.com>
Reviewed-by: default avatarJulien Thierry <julien.thierry@arm.com>
Reviewed-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 6f4d2a0b

virt/kvm/arm/pmu.c

+33 −9
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
#include <kvm/arm_pmu.h>

#include <kvm/arm_vgic.h>



static void kvm_pmu_create_perf_event(struct kvm_vcpu *vcpu, u64 select_idx);

/**

 * kvm_pmu_get_counter_value - get PMU counter value

 * @vcpu: The vcpu pointer
@@ -51,6 +52,9 @@ void kvm_pmu_set_counter_value(struct kvm_vcpu *vcpu, u64 select_idx, u64 val) 
	reg = (select_idx == ARMV8_PMU_CYCLE_IDX)

	      ? PMCCNTR_EL0 : PMEVCNTR0_EL0 + select_idx;

	__vcpu_sys_reg(vcpu, reg) += (s64)val - kvm_pmu_get_counter_value(vcpu, select_idx);



	/* Recreate the perf event to reflect the updated sample_period */

	kvm_pmu_create_perf_event(vcpu, select_idx);

}



/**
@@ -367,23 +371,21 @@ static bool kvm_pmu_counter_is_enabled(struct kvm_vcpu *vcpu, u64 select_idx) 
}



/**

 * kvm_pmu_set_counter_event_type - set selected counter to monitor some event

 * kvm_pmu_create_perf_event - create a perf event for a counter

 * @vcpu: The vcpu pointer

 * @data: The data guest writes to PMXEVTYPER_EL0

 * @select_idx: The number of selected counter

 *

 * When OS accesses PMXEVTYPER_EL0, that means it wants to set a PMC to count an

 * event with given hardware event number. Here we call perf_event API to

 * emulate this action and create a kernel perf event for it.

 */

void kvm_pmu_set_counter_event_type(struct kvm_vcpu *vcpu, u64 data,

				    u64 select_idx)

static void kvm_pmu_create_perf_event(struct kvm_vcpu *vcpu, u64 select_idx)

{

	struct kvm_pmu *pmu = &vcpu->arch.pmu;

	struct kvm_pmc *pmc = &pmu->pmc[select_idx];

	struct perf_event *event;

	struct perf_event_attr attr;

	u64 eventsel, counter;

	u64 eventsel, counter, reg, data;



	reg = (select_idx == ARMV8_PMU_CYCLE_IDX)

	      ? PMCCFILTR_EL0 : PMEVTYPER0_EL0 + select_idx;

	data = __vcpu_sys_reg(vcpu, reg);



	kvm_pmu_stop_counter(vcpu, pmc);

	eventsel = data & ARMV8_PMU_EVTYPE_EVENT;
@@ -420,6 +422,28 @@ void kvm_pmu_set_counter_event_type(struct kvm_vcpu *vcpu, u64 data, 
	pmc->perf_event = event;

}



/**

 * kvm_pmu_set_counter_event_type - set selected counter to monitor some event

 * @vcpu: The vcpu pointer

 * @data: The data guest writes to PMXEVTYPER_EL0

 * @select_idx: The number of selected counter

 *

 * When OS accesses PMXEVTYPER_EL0, that means it wants to set a PMC to count an

 * event with given hardware event number. Here we call perf_event API to

 * emulate this action and create a kernel perf event for it.

 */

void kvm_pmu_set_counter_event_type(struct kvm_vcpu *vcpu, u64 data,

				    u64 select_idx)

{

	u64 reg, event_type = data & ARMV8_PMU_EVTYPE_MASK;



	reg = (select_idx == ARMV8_PMU_CYCLE_IDX)

	      ? PMCCFILTR_EL0 : PMEVTYPER0_EL0 + select_idx;



	__vcpu_sys_reg(vcpu, reg) = event_type;

	kvm_pmu_create_perf_event(vcpu, select_idx);

}



bool kvm_arm_support_pmu_v3(void)

{

	/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE