staging: rtl8712: init_default_value(): Change return type (30d83c80) · Commits · 戴 / test

Change return type of init_default_value from u8 to void as it always returns _SUCCESS. Remove now-unnecessary return statement. Modify call site to simply call the function. Signed-off-by:

Nishka Dasgupta <nishkadg.linux@gmail.com> Link: https://lore.kernel.org/r/20190808064012.12661-6-nishkadg.linux@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8712/os_intfs.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -258,7 +258,7 @@ void r8712_stop_drv_timers(struct _adapter *padapter)
		del_timer_sync(&padapter->mlmepriv.sitesurveyctrl.sitesurvey_ctrl_timer);
		}

		static u8 init_default_value(struct _adapter *padapter)
		static void init_default_value(struct _adapter *padapter)
		{
		struct registry_priv *pregistrypriv = &padapter->registrypriv;
		struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
		@@ -292,7 +292,6 @@ static u8 init_default_value(struct _adapter *padapter)
		r8712_init_registrypriv_dev_network(padapter);
		r8712_update_registrypriv_dev_network(padapter);
		/misc./
		return _SUCCESS;
		}

		u8 r8712_init_drv_sw(struct _adapter *padapter)
		@@ -316,8 +315,7 @@ u8 r8712_init_drv_sw(struct _adapter *padapter)
		r8712_init_bcmc_stainfo(padapter);
		r8712_init_pwrctrl_priv(padapter);
		mp871xinit(padapter);
		if (init_default_value(padapter) != _SUCCESS)
		return _FAIL;
		init_default_value(padapter);
		r8712_InitSwLeds(padapter);
		return _SUCCESS;
		}

Admin message