Commit 30d41e18 authored Mar 20, 2020 by Weihang Li Committed by Jason Gunthorpe Mar 26, 2020

RDMA/hns: Fix a wrong judgment of return value

hns_roce_alloc_mtt_range() never return -1, ret should be checked
whether it is zero instead of -1.

Fixes: 1ceb0b11 ("RDMA/hns: Fix non-standard error codes")
Link: https://lore.kernel.org/r/1584674622-52773-3-git-send-email-liweihang@huawei.com


Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent ae1c6148

drivers/infiniband/hw/hns/hns_roce_mr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -243,7 +243,7 @@ int hns_roce_mtt_init(struct hns_roce_dev *hr_dev, int npages, int page_shift,
		/* Allocate MTT entry */
		ret = hns_roce_alloc_mtt_range(hr_dev, mtt->order, &mtt->first_seg,
		mtt->mtt_type);
		if (ret == -1)
		if (ret)
		return -ENOMEM;

		return 0;

Admin message