Commit 30cdd69e authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Ingo Molnar
Browse files

cpuidle/idle: Move the cpuidle_idle_call function to idle.c 



The cpuidle_idle_call does nothing more than calling the three individuals
function and is no longer used by any arch specific code but only in the
cpuidle framework code.

We can move this function into the idle task code to ensure better
proximity to the scheduler code.

Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: default avatarNicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Cc: rjw@rjwysocki.net
Cc: preeti@linux.vnet.ibm.com
Link: http://lkml.kernel.org/r/1393832934-11625-2-git-send-email-daniel.lezcano@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 907e30f1

drivers/cpuidle/cpuidle.c

+0 −49
Original line number Diff line number Diff line
@@ -172,55 +172,6 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index) 
		cpuidle_curr_governor->reflect(dev, index);

}



/**

 * cpuidle_idle_call - the main idle loop

 *

 * NOTE: no locks or semaphores should be used here

 * return non-zero on failure

 */

int cpuidle_idle_call(void)

{

	struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);

	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);

	int next_state, entered_state, ret;

	bool broadcast;



	ret = cpuidle_enabled(drv, dev);

	if (ret < 0)

		return ret;



	/* ask the governor for the next state */

	next_state = cpuidle_select(drv, dev);



	if (need_resched()) {

		dev->last_residency = 0;

		/* give the governor an opportunity to reflect on the outcome */

		cpuidle_reflect(dev, next_state);

		local_irq_enable();

		return 0;

	}



	broadcast = !!(drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP);



	if (broadcast &&

	    clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu))

		return -EBUSY;



	trace_cpu_idle_rcuidle(next_state, dev->cpu);



	entered_state = cpuidle_enter(drv, dev, next_state);



	trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu);



	if (broadcast)

		clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu);



	/* give the governor an opportunity to reflect on the outcome */

	cpuidle_reflect(dev, entered_state);



	return 0;

}



/**

 * cpuidle_install_idle_handler - installs the cpuidle idle loop handler

 */

include/linux/cpuidle.h

+0 −2
Original line number Diff line number Diff line
@@ -128,7 +128,6 @@ extern int cpuidle_enter(struct cpuidle_driver *drv, 
			 struct cpuidle_device *dev, int index);

extern void cpuidle_reflect(struct cpuidle_device *dev, int index);



extern int cpuidle_idle_call(void);

extern int cpuidle_register_driver(struct cpuidle_driver *drv);

extern struct cpuidle_driver *cpuidle_get_driver(void);

extern struct cpuidle_driver *cpuidle_driver_ref(void);
@@ -160,7 +159,6 @@ static inline int cpuidle_enter(struct cpuidle_driver *drv, 
				struct cpuidle_device *dev, int index)

{return -ENODEV; }

static inline void cpuidle_reflect(struct cpuidle_device *dev, int index) { }

static inline int cpuidle_idle_call(void) { return -ENODEV; }

static inline int cpuidle_register_driver(struct cpuidle_driver *drv)

{return -ENODEV; }

static inline struct cpuidle_driver *cpuidle_get_driver(void) {return NULL; }

kernel/sched/idle.c

+56 −0
Original line number Diff line number Diff line
@@ -63,6 +63,62 @@ void __weak arch_cpu_idle(void) 
	local_irq_enable();

}



#ifdef CONFIG_CPU_IDLE

/**

 * cpuidle_idle_call - the main idle function

 *

 * NOTE: no locks or semaphores should be used here

 * return non-zero on failure

 */

static int cpuidle_idle_call(void)

{

	struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);

	struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);

	int next_state, entered_state, ret;

	bool broadcast;



	ret = cpuidle_enabled(drv, dev);

	if (ret < 0)

		return ret;



	/* ask the governor for the next state */

	next_state = cpuidle_select(drv, dev);



	if (need_resched()) {

		dev->last_residency = 0;

		/* give the governor an opportunity to reflect on the outcome */

		cpuidle_reflect(dev, next_state);

		local_irq_enable();

		return 0;

	}



	broadcast = !!(drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP);



	if (broadcast &&

	    clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu))

		return -EBUSY;



	trace_cpu_idle_rcuidle(next_state, dev->cpu);



	entered_state = cpuidle_enter(drv, dev, next_state);



	trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu);



	if (broadcast)

		clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu);



	/* give the governor an opportunity to reflect on the outcome */

	cpuidle_reflect(dev, entered_state);



	return 0;

}

#else

static inline int cpuidle_idle_call(void)

{

	return -ENODEV;

}

#endif



/*

 * Generic idle loop implementation

 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE