Commit 30c1dc0f authored May 23, 2012 by Tushar Behera Committed by Vinod Koul Jun 07, 2012

dmaengine: pl330: dont complete descriptor for cyclic dma



Commit eab21585 ("dmaengine: pl330: dont complete descriptor for
cyclic dma") wrongly completes descriptor for cyclic dma, hence following
BUG_ON is still hit with cyclic DMA operations.

kernel BUG at drivers/dma/dmaengine.h:53!

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Cc: stable <stable@vger.kernel.org>

parent f8f5701b

drivers/dma/pl330.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2321,7 +2321,7 @@ static void pl330_tasklet(unsigned long data)
		/* Pick up ripe tomatoes */
		list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
		if (desc->status == DONE) {
		if (pch->cyclic)
		if (!pch->cyclic)
		dma_cookie_complete(&desc->txd);
		list_move_tail(&desc->node, &list);
		}

Admin message