Commit 30aecae8 authored Oct 04, 2019 by Andrew Price Committed by Andreas Gruenbacher Oct 24, 2019

gfs2: Fix memory leak when gfs2meta's fs_context is freed



gfs2 and gfs2meta share an ->init_fs_context function which allocates an
args structure stored in fc->fs_private. gfs2 registers a ->free
function to free this memory when the fs_context is cleaned up, but
there was not one registered for gfs2meta, causing a leak.

Register a ->free function for gfs2meta. The existing gfs2_fc_free
function does what we need.

Reported-by:  <syzbot+c2fdfd2b783754878fb6@syzkaller.appspotmail.com>
Fixes: 1f52aa08 ("gfs2: Convert gfs2 to fs_context")
Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent 7d194c21

fs/gfs2/ops_fstype.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1600,6 +1600,7 @@ static int gfs2_meta_get_tree(struct fs_context *fc)
		}

		static const struct fs_context_operations gfs2_meta_context_ops = {
		.free = gfs2_fc_free,
		.get_tree = gfs2_meta_get_tree,
		};

Admin message