Commit 309caa9c authored Jun 21, 2010 by Russell King

ARM: Prohibit ioremap() on kernel managed RAM



ARMv6 and above have a restriction whereby aliasing virtual:physical
mappings must not have differing memory type and sharability
attributes.  Strictly, this covers the memory type (strongly ordered,
device, memory), cache attributes (uncached, write combine, write
through, write back read alloc, write back write alloc) and the
shared bit.

However, using ioremap() and its variants on system RAM results in
mappings which differ in these attributes from the main system RAM
mapping.  Other architectures which similar restrictions approch this
problem in the same way - they do not permit ioremap on main system
RAM.

Make ARM behave in the same way, with a WARN_ON() such that users can
be traced and an alternative approach found.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 7e27d6e7

arch/arm/mm/ioremap.c

+6 −0

Original line number	Original line	Diff line number	Diff line
	@@ -268,6 +268,12 @@ void __iomem * __arm_ioremap_pfn_caller(unsigned long pfn,
	if (pfn >= 0x100000 && (__pfn_to_phys(pfn) & ~SUPERSECTION_MASK))		if (pfn >= 0x100000 && (__pfn_to_phys(pfn) & ~SUPERSECTION_MASK))
	return NULL;		return NULL;

			/*
			* Don't allow RAM to be mapped - this causes problems with ARMv6+
			*/
			if (WARN_ON(pfn_valid(pfn)))
			return NULL;

	type = get_mem_type(mtype);		type = get_mem_type(mtype);
	if (!type)		if (!type)
	return NULL;		return NULL;

Admin message