Commit 308cc8d8 authored Aug 06, 2014 by Joe Perches Committed by Linus Torvalds Aug 06, 2014

checkpatch: fix false positives for --strict "space after cast" test



Commit 89da401f6cff ("checkpatch: improve "no space after cast" test")
in -next improved the cast test for non pointer types, but also
introduced false positives for some types of static inlines.

Add a test for an open brace to the exclusions to avoid these false
positives.

Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Hartley Sweeten <HartleyS@visionengravers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e81f239b

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -2456,7 +2456,7 @@ sub process {
		}
		}

		if ($line =~ /^\+.$\s$Type\s*$[ \t]+(?!$Assignment\|$Arithmetic)/) {
		if ($line =~ /^\+.$\s$Type\s*$[ \t]+(?!$Assignment\|$Arithmetic\|{)/) {
		if (CHK("SPACING",
		"No space is necessary after a cast\n" . $herecurr) &&
		$fix) {

Admin message