Commit 308be6c7 authored Mar 26, 2019 by Mathieu Malaterre Committed by Michael Ellerman Apr 20, 2019

powerpc/embedded6xx: Make some functions static

In commit cb9e4d10 ("[POWERPC] Add support for 750CL Holly board")
new functions were added. Since most of these functions can be made
static, make it so.

Both holly_power_off and holly_halt functions were not changed since
they are unused, making them static would have triggered the following
warning (treated as error):

arch/powerpc/platforms/embedded6xx/holly.c:244:13: error: 'holly_halt' defined but not used

Silence the following warnings triggered using W=1:

arch/powerpc/platforms/embedded6xx/holly.c:47:5: error: no previous prototype for 'holly_exclude_device'
arch/powerpc/platforms/embedded6xx/holly.c:190:6: error: no previous prototype for 'holly_show_cpuinfo'
arch/powerpc/platforms/embedded6xx/holly.c:196:17: error: no previous prototype for 'holly_restart'

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent ff6d2782

arch/powerpc/platforms/embedded6xx/holly.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -44,7 +44,8 @@

		#define HOLLY_PCI_CFG_PHYS 0x7c000000

		int holly_exclude_device(struct pci_controller *hose, u_char bus, u_char devfn)
		static int holly_exclude_device(struct pci_controller *hose, u_char bus,
		u_char devfn)
		{
		if (bus == 0 && PCI_SLOT(devfn) == 0)
		return PCIBIOS_DEVICE_NOT_FOUND;
		@@ -187,13 +188,13 @@ static void __init holly_init_IRQ(void)
		tsi108_write_reg(TSI108_MPIC_OFFSET + 0x30c, 0);
		}

		void holly_show_cpuinfo(struct seq_file *m)
		static void holly_show_cpuinfo(struct seq_file *m)
		{
		seq_printf(m, "vendor\t\t: IBM\n");
		seq_printf(m, "machine\t\t: PPC750 GX/CL\n");
		}

		void __noreturn holly_restart(char *cmd)
		static void __noreturn holly_restart(char *cmd)
		{
		__be32 __iomem *ocn_bar1 = NULL;
		unsigned long bar;

Admin message