Commit 30780d08 authored Jan 07, 2020 by Arnd Bergmann Committed by David S. Miller Jan 08, 2020

atm: eni: fix uninitialized variable warning



With -O3, gcc has found an actual unintialized variable stored
into an mmio register in two instances:

drivers/atm/eni.c: In function 'discard':
drivers/atm/eni.c:465:13: error: 'dma[1]' is used uninitialized in this function [-Werror=uninitialized]
   writel(dma[i*2+1],eni_dev->rx_dma+dma_wr*8+4);
             ^
drivers/atm/eni.c:465:13: error: 'dma[3]' is used uninitialized in this function [-Werror=uninitialized]

Change the code to always write zeroes instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 96cc4b69

drivers/atm/eni.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -374,7 +374,7 @@ static int do_rx_dma(struct atm_vcc vcc,struct sk_buff skb,
		here = (eni_vcc->descr+skip) & (eni_vcc->words-1);
		dma[j++] = (here << MID_DMA_COUNT_SHIFT) \| (vcc->vci
		<< MID_DMA_VCI_SHIFT) \| MID_DT_JK;
		j++;
		dma[j++] = 0;
		}
		here = (eni_vcc->descr+size+skip) & (eni_vcc->words-1);
		if (!eff) size += skip;
		@@ -447,7 +447,7 @@ static int do_rx_dma(struct atm_vcc vcc,struct sk_buff skb,
		if (size != eff) {
		dma[j++] = (here << MID_DMA_COUNT_SHIFT) \|
		(vcc->vci << MID_DMA_VCI_SHIFT) \| MID_DT_JK;
		j++;
		dma[j++] = 0;
		}
		if (!j \|\| j > 2*RX_DMA_BUF) {
		printk(KERN_CRIT DEV_LABEL "!j or j too big!!!\n");

Admin message