Commit 3070da33 authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

sched,spi: Convert to sched_set_fifo*() 



Because SCHED_FIFO is a broken scheduler model (see previous patches)
take away the priority field, the kernel can't possibly make an
informed decision.

No effective change.

Cc: broonie@kernel.org
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
parent f8ec806b

drivers/platform/chrome/cros_ec_spi.c

+1 −5
Original line number Diff line number Diff line
@@ -709,9 +709,6 @@ static void cros_ec_spi_high_pri_release(void *worker) 
static int cros_ec_spi_devm_high_pri_alloc(struct device *dev,

					   struct cros_ec_spi *ec_spi)

{

	struct sched_param sched_priority = {

		.sched_priority = MAX_RT_PRIO / 2,

	};

	int err;



	ec_spi->high_pri_worker =
@@ -728,8 +725,7 @@ static int cros_ec_spi_devm_high_pri_alloc(struct device *dev, 
	if (err)

		return err;



	err = sched_setscheduler_nocheck(ec_spi->high_pri_worker->task,

					 SCHED_FIFO, &sched_priority);

	err = sched_set_fifo(ec_spi->high_pri_worker->task);

	if (err)

		dev_err(dev, "Can't set cros_ec high pri priority: %d\n", err);

	return err;

drivers/spi/spi.c

+1 −3
Original line number Diff line number Diff line
@@ -1592,11 +1592,9 @@ EXPORT_SYMBOL_GPL(spi_take_timestamp_post); 
 */

static void spi_set_thread_rt(struct spi_controller *ctlr)

{

	struct sched_param param = { .sched_priority = MAX_RT_PRIO / 2 };



	dev_info(&ctlr->dev,

		"will run message pump with realtime priority\n");

	sched_setscheduler(ctlr->kworker_task, SCHED_FIFO, &param);

	sched_set_fifo(ctlr->kworker_task);

}



static int spi_init_queue(struct spi_controller *ctlr)

CRA Git | Maintained and supported by SUSTech CRA and CCSE