Commit 3056e3ae authored Jun 04, 2013 by Alex Lyakas Committed by NeilBrown Jun 13, 2013

md/raid1: consider WRITE as successful only if at least one non-Faulty and...


md/raid1: consider WRITE as successful only if at least one non-Faulty and non-rebuilding drive completed it.

Without that fix, the following scenario could happen:

- RAID1 with drives A and B; drive B was freshly-added and is rebuilding
- Drive A fails
- WRITE request arrives to the array. It is failed by drive A, so
r1_bio is marked as R1BIO_WriteError, but the rebuilding drive B
succeeds in writing it, so the same r1_bio is marked as
R1BIO_Uptodate.
- r1_bio arrives to handle_write_finished, badblocks are disabled,
md_error()->error() does nothing because we don't fail the last drive
of raid1
- raid_end_bio_io()  calls call_bio_endio()
- As a result, in call_bio_endio():
        if (!test_bit(R1BIO_Uptodate, &r1_bio->state))
                clear_bit(BIO_UPTODATE, &bio->bi_flags);
this code doesn't clear the BIO_UPTODATE flag, and the whole master
WRITE succeeds, back to the upper layer.

So we returned success to the upper layer, even though we had written
the data onto the rebuilding drive only. But when we want to read the
data back, we would not read from the rebuilding drive, so this data
is lost.

[neilb - applied identical change to raid10 as well]

This bug can result in lost data, so it is suitable for any
-stable kernel.

Cc: stable@vger.kernel.org
Signed-off-by: Alex Lyakas <alex@zadarastorage.com>
Signed-off-by: NeilBrown <neilb@suse.de>

parent 6b6204ee

drivers/md/raid1.c

+11 −1

Original line number	Diff line number	Diff line
		@@ -427,6 +427,16 @@ static void raid1_end_write_request(struct bio *bio, int error)

		r1_bio->bios[mirror] = NULL;
		to_put = bio;
		/*
		* Do not set R1BIO_Uptodate if the current device is
		* rebuilding or Faulty. This is because we cannot use
		* such device for properly reading the data back (we could
		* potentially use it, if the current write would have felt
		* before rdev->recovery_offset, but for simplicity we don't
		* check this here.
		*/
		if (test_bit(In_sync, &conf->mirrors[mirror].rdev->flags) &&
		!test_bit(Faulty, &conf->mirrors[mirror].rdev->flags))
		set_bit(R1BIO_Uptodate, &r1_bio->state);

		/* Maybe we can clear some bad blocks. */

drivers/md/raid10.c

+11 −1

Original line number	Diff line number	Diff line
		@@ -490,6 +490,16 @@ static void raid10_end_write_request(struct bio *bio, int error)
		sector_t first_bad;
		int bad_sectors;

		/*
		* Do not set R10BIO_Uptodate if the current device is
		* rebuilding or Faulty. This is because we cannot use
		* such device for properly reading the data back (we could
		* potentially use it, if the current write would have felt
		* before rdev->recovery_offset, but for simplicity we don't
		* check this here.
		*/
		if (test_bit(In_sync, &rdev->flags) &&
		!test_bit(Faulty, &rdev->flags))
		set_bit(R10BIO_Uptodate, &r10_bio->state);

		/* Maybe we can clear some bad blocks. */

Admin message