Commit 304d427c authored by Artem Bityutskiy's avatar Artem Bityutskiy
Browse files

UBIFS: fix file-system synchronization 



Argh. The ->sync_fs call is called _before_ all inodes are flushed.
This means we first sync write buffers and commit, then all
inodes are synced, and we end up with unflushed write buffers!

Fix this by forcing synching all indoes from 'ubifs_sync_fs()'.

Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
parent 79807d07

fs/ubifs/super.c

+18 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ 
#include <linux/seq_file.h>

#include <linux/mount.h>

#include <linux/math64.h>

#include <linux/writeback.h>

#include "ubifs.h"



/*
@@ -431,6 +432,23 @@ static int ubifs_sync_fs(struct super_block *sb, int wait) 
	struct ubifs_info *c = sb->s_fs_info;

	int i, ret = 0, err;

	long long bud_bytes;

	struct writeback_control wbc = {

		.sync_mode   = wait ? WB_SYNC_ALL : WB_SYNC_HOLD,

		.range_start = 0,

		.range_end   = LLONG_MAX,

		.nr_to_write = LONG_MAX,

	};



	/*

	 * VFS calls '->sync_fs()' before synchronizing all dirty inodes and

	 * pages, so synchronize them first, then commit the journal. Strictly

	 * speaking, it is not necessary to commit the journal here,

	 * synchronizing write-buffers would be enough. But committing makes

	 * UBIFS free space predictions much more accurate, so we want to let

	 * the user be able to get more accurate results of 'statfs()' after

	 * they synchronize the file system.

	 */

	generic_sync_sb_inodes(sb, &wbc);



	if (c->jheads) {

		for (i = 0; i < c->jhead_cnt; i++) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE