Commit 30353bfc authored by Leon Romanovsky's avatar Leon Romanovsky Committed by David S. Miller
Browse files

net/mlx4_core: Use RCU to perform radix tree lookup for SRQ 



Radix tree lookup can be performed without locking.

Fixes: 225c7b1f ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters")
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Suggested-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57c970c2

drivers/net/ethernet/mellanox/mlx4/srq.c

+5 −9
Original line number Diff line number Diff line
@@ -45,15 +45,12 @@ void mlx4_srq_event(struct mlx4_dev *dev, u32 srqn, int event_type) 
	struct mlx4_srq_table *srq_table = &mlx4_priv(dev)->srq_table;

	struct mlx4_srq *srq;



	spin_lock(&srq_table->lock);



	rcu_read_lock();

	srq = radix_tree_lookup(&srq_table->tree, srqn & (dev->caps.num_srqs - 1));

	rcu_read_unlock();

	if (srq)

		atomic_inc(&srq->refcount);



	spin_unlock(&srq_table->lock);



	if (!srq) {

	else {

		mlx4_warn(dev, "Async event for bogus SRQ %08x\n", srqn);

		return;

	}
@@ -301,12 +298,11 @@ struct mlx4_srq *mlx4_srq_lookup(struct mlx4_dev *dev, u32 srqn) 
{

	struct mlx4_srq_table *srq_table = &mlx4_priv(dev)->srq_table;

	struct mlx4_srq *srq;

	unsigned long flags;



	spin_lock_irqsave(&srq_table->lock, flags);

	rcu_read_lock();

	srq = radix_tree_lookup(&srq_table->tree,

				srqn & (dev->caps.num_srqs - 1));

	spin_unlock_irqrestore(&srq_table->lock, flags);

	rcu_read_unlock();



	return srq;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE