Commit 30336ef6 authored Jul 11, 2020 by Andy Shevchenko Committed by Greg Kroah-Hartman Jul 21, 2020

Revert "serial: sunhv: Initialize lock for non-registered console"

This reverts commit 0f87aa66.

There has been a quick fix against uninitialised lock revealed by
the commit f743061a ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: 0f87aa66 ("serial: sunhv: Initialize lock for non-registered console")
Depends-on: f743061a ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-1-andriy.shevchenko@linux.intel.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6f2c6599

drivers/tty/serial/sunhv.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -567,9 +567,6 @@ static int hv_probe(struct platform_device *op)
		sunserial_console_match(&sunhv_console, op->dev.of_node,
		&sunhv_reg, port->line, false);

		/* We need to initialize lock even for non-registered console */
		spin_lock_init(&port->lock);

		err = uart_add_one_port(&sunhv_reg, port);
		if (err)
		goto out_unregister_driver;