Commit 3024ba2d authored Apr 09, 2020 by Coly Li Committed by Song Liu May 13, 2020

md: remove redundant memalloc scope API usage



In mddev_create_serial_pool(), memalloc scope APIs memalloc_noio_save()
and memalloc_noio_restore() are used when allocating memory by calling
mempool_create_kmalloc_pool(). After adding the memalloc scope APIs in
raid array suspend context, it is unncessary to explicitly call them
around mempool_create_kmalloc_pool() any longer.

This patch removes the redundant memalloc scope APIs in
mddev_create_serial_pool().

Signed-off-by: Coly Li <colyli@suse.de>
Cc: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Song Liu <songliubraving@fb.com>

parent 7f8a30e5

drivers/md/md.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -228,13 +228,13 @@ void mddev_create_serial_pool(struct mddev mddev, struct md_rdev rdev,
		goto abort;

		if (mddev->serial_info_pool == NULL) {
		unsigned int noio_flag;

		noio_flag = memalloc_noio_save();
		/*
		* already in memalloc noio context by
		* mddev_suspend()
		*/
		mddev->serial_info_pool =
		mempool_create_kmalloc_pool(NR_SERIAL_INFOS,
		sizeof(struct serial_info));
		memalloc_noio_restore(noio_flag);
		if (!mddev->serial_info_pool) {
		rdevs_uninit_serial(mddev);
		pr_err("can't alloc memory pool for serialization\n");

Admin message