[SCSI] libiscsi: don't let io sit in queue when session has failed (301e0f7e) · Commits · 戴 / test

If the session is failed, but we have not yet fully transitioned to the recovery stage we were still queueuing IO. The idea is that for some failures we can recvover at the command level and still continue to execute other IO. Well, we never have added the recovery within a command code, so queueing up IO here just creates the possibility that it might time time out so this just has us requeue the IO the scsi layer for now. Signed-off-by:

Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:

James Bottomley <James.Bottomley@HansenPartnership.com>

drivers/scsi/libiscsi.c

+6 −9

Original line number	Diff line number	Diff line
		@@ -1390,13 +1390,7 @@ int iscsi_queuecommand(struct scsi_cmnd sc, void (done)(struct scsi_cmnd *))
		goto fault;
		}

		/*
		* ISCSI_STATE_FAILED is a temp. state. The recovery
		* code will decide what is best to do with command queued
		* during this time
		*/
		if (session->state != ISCSI_STATE_LOGGED_IN &&
		session->state != ISCSI_STATE_FAILED) {
		if (session->state != ISCSI_STATE_LOGGED_IN) {
		/*
		* to handle the race between when we set the recovery state
		* and block the session we requeue here (commands could
		@@ -1404,12 +1398,15 @@ int iscsi_queuecommand(struct scsi_cmnd sc, void (done)(struct scsi_cmnd *))
		* up because the block code is not locked)
		*/
		switch (session->state) {
		case ISCSI_STATE_FAILED:
		case ISCSI_STATE_IN_RECOVERY:
		reason = FAILURE_SESSION_IN_RECOVERY;
		goto reject;
		sc->result = DID_IMM_RETRY << 16;
		break;
		case ISCSI_STATE_LOGGING_OUT:
		reason = FAILURE_SESSION_LOGGING_OUT;
		goto reject;
		sc->result = DID_IMM_RETRY << 16;
		break;
		case ISCSI_STATE_RECOVERY_FAILED:
		reason = FAILURE_SESSION_RECOVERY_TIMEOUT;
		sc->result = DID_TRANSPORT_FAILFAST << 16;

Admin message