Commit 30042072 authored Nov 16, 2011 by Jiri Slaby Committed by Greg Kroah-Hartman Nov 17, 2011

TTY: ldisc, move wait idle to caller



It is the only place where reinit is called from. And we really need
to wait for the old ldisc to go once. Actually this is the place where
the waiting originally was (before removed and re-added later).

This will make the fix in the following patch easier to implement.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Dave Young <hidave.darkstar@gmail.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Dmitriy Matrosov <sgf.dma@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent df92d056

drivers/tty/tty_ldisc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -763,8 +763,6 @@ static int tty_ldisc_reinit(struct tty_struct *tty, int ldisc)
		if (IS_ERR(ld))
		return -1;

		WARN_ON_ONCE(tty_ldisc_wait_idle(tty, 5 * HZ));

		tty_ldisc_close(tty, tty->ldisc);
		tty_ldisc_put(tty->ldisc);
		tty->ldisc = NULL;
		@@ -848,6 +846,8 @@ void tty_ldisc_hangup(struct tty_struct *tty)
		it means auditing a lot of other paths so this is
		a FIXME */
		if (tty->ldisc) { /* Not yet closed */
		WARN_ON_ONCE(tty_ldisc_wait_idle(tty, 5 * HZ));

		if (reset == 0) {

		if (!tty_ldisc_reinit(tty, tty->termios->c_line))

Admin message