Commit 2ff8fe13 authored by Viresh Kumar's avatar Viresh Kumar
Browse files

cpufreq: qcom-cpufreq-nvmem: dev_pm_opp_put_*() accepts NULL argument 



The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
there is no need for us to carry the extra checks. Drop them.

Reviewed-by: default avatarIlia Lin <ilia.lin@kernel.org>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 5f6ffb8d

drivers/cpufreq/qcom-cpufreq-nvmem.c

+6 −9
Original line number Diff line number Diff line
@@ -397,19 +397,19 @@ static int qcom_cpufreq_probe(struct platform_device *pdev) 


free_genpd_opp:

	for_each_possible_cpu(cpu) {

		if (IS_ERR_OR_NULL(drv->genpd_opp_tables[cpu]))

		if (IS_ERR(drv->genpd_opp_tables[cpu]))

			break;

		dev_pm_opp_detach_genpd(drv->genpd_opp_tables[cpu]);

	}

	kfree(drv->genpd_opp_tables);

free_opp:

	for_each_possible_cpu(cpu) {

		if (IS_ERR_OR_NULL(drv->names_opp_tables[cpu]))

		if (IS_ERR(drv->names_opp_tables[cpu]))

			break;

		dev_pm_opp_put_prop_name(drv->names_opp_tables[cpu]);

	}

	for_each_possible_cpu(cpu) {

		if (IS_ERR_OR_NULL(drv->hw_opp_tables[cpu]))

		if (IS_ERR(drv->hw_opp_tables[cpu]))

			break;

		dev_pm_opp_put_supported_hw(drv->hw_opp_tables[cpu]);

	}
@@ -430,11 +430,8 @@ static int qcom_cpufreq_remove(struct platform_device *pdev) 
	platform_device_unregister(cpufreq_dt_pdev);



	for_each_possible_cpu(cpu) {

		if (drv->names_opp_tables[cpu])

		dev_pm_opp_put_supported_hw(drv->names_opp_tables[cpu]);

		if (drv->hw_opp_tables[cpu])

		dev_pm_opp_put_supported_hw(drv->hw_opp_tables[cpu]);

		if (drv->genpd_opp_tables[cpu])

		dev_pm_opp_detach_genpd(drv->genpd_opp_tables[cpu]);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE