Commit 2ff08678 authored by Karsten Graul's avatar Karsten Graul Committed by David S. Miller
Browse files

net/smc: drop out-of-flow llc response messages 



To be save from unexpected or late llc response messages check if the
arrived message fits to the current flow type and drop out-of-flow
messages. And drop it when there is already a response assigned to
the flow.

Reviewed-by: default avatarUrsula Braun <ubraun@linux.ibm.com>
Fixes: ef79d439 ("net/smc: process llc responses in tasklet context")
Signed-off-by: default avatarKarsten Graul <kgraul@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 63673597

net/smc/smc_llc.c

+18 −6
Original line number Diff line number Diff line
@@ -1587,6 +1587,8 @@ again: 
static void smc_llc_rx_response(struct smc_link *link,

				struct smc_llc_qentry *qentry)

{

	enum smc_llc_flowtype flowtype = link->lgr->llc_flow_lcl.type;

	struct smc_llc_flow *flow = &link->lgr->llc_flow_lcl;

	u8 llc_type = qentry->msg.raw.hdr.common.type;



	switch (llc_type) {
@@ -1595,15 +1597,20 @@ static void smc_llc_rx_response(struct smc_link *link, 
			complete(&link->llc_testlink_resp);

		break;

	case SMC_LLC_ADD_LINK:

	case SMC_LLC_DELETE_LINK:

	case SMC_LLC_CONFIRM_LINK:

	case SMC_LLC_ADD_LINK_CONT:

	case SMC_LLC_CONFIRM_LINK:

		if (flowtype != SMC_LLC_FLOW_ADD_LINK || flow->qentry)

			break;	/* drop out-of-flow response */

		goto assign;

	case SMC_LLC_DELETE_LINK:

		if (flowtype != SMC_LLC_FLOW_DEL_LINK || flow->qentry)

			break;	/* drop out-of-flow response */

		goto assign;

	case SMC_LLC_CONFIRM_RKEY:

	case SMC_LLC_DELETE_RKEY:

		/* assign responses to the local flow, we requested them */

		smc_llc_flow_qentry_set(&link->lgr->llc_flow_lcl, qentry);

		wake_up(&link->lgr->llc_msg_waiter);

		return;

		if (flowtype != SMC_LLC_FLOW_RKEY || flow->qentry)

			break;	/* drop out-of-flow response */

		goto assign;

	case SMC_LLC_CONFIRM_RKEY_CONT:

		/* not used because max links is 3 */

		break;
@@ -1612,6 +1619,11 @@ static void smc_llc_rx_response(struct smc_link *link, 
		break;

	}

	kfree(qentry);

	return;

assign:

	/* assign responses to the local flow, we requested them */

	smc_llc_flow_qentry_set(&link->lgr->llc_flow_lcl, qentry);

	wake_up(&link->lgr->llc_msg_waiter);

}



static void smc_llc_enqueue(struct smc_link *link, union smc_llc_msg *llc)

CRA Git | Maintained and supported by SUSTech CRA and CCSE