Commit 2feb55f8 authored Feb 16, 2016 by Wouter van Kesteren Committed by Al Viro Feb 20, 2016

fs: allow no_seek_end_llseek to actually seek



The user-visible impact of the issue is for example that without this
patch sensors-detect breaks when trying to seek in /dev/cpu/0/cpuid.

'~0ULL' is a 'unsigned long long' that when converted to a loff_t,
which is signed, gets turned into -1. later in vfs_setpos we have
'if (offset > maxsize)', which makes it always return EINVAL.

Fixes: b25472f9 ("new helpers: no_seek_end_llseek{,_size}()")
Signed-off-by: Wouter van Kesteren <woutershep@gmail.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 18558cae

fs/read_write.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -17,6 +17,7 @@
		#include <linux/splice.h>
		#include <linux/compat.h>
		#include <linux/mount.h>
		#include <linux/fs.h>
		#include "internal.h"

		#include <asm/uaccess.h>
		@@ -183,7 +184,7 @@ loff_t no_seek_end_llseek(struct file *file, loff_t offset, int whence)
		switch (whence) {
		case SEEK_SET: case SEEK_CUR:
		return generic_file_llseek_size(file, offset, whence,
		~0ULL, 0);
		OFFSET_MAX, 0);
		default:
		return -EINVAL;
		}

Admin message