Commit 2fe97a57 authored Nov 28, 2019 by Tung Nguyen Committed by David S. Miller Nov 28, 2019

tipc: fix potential memory leak in __tipc_sendmsg()



When initiating a connection message to a server side, the connection
message is cloned and added to the socket write queue. However, if the
cloning is failed, only the socket write queue is purged. It causes
memory leak because the original connection message is not freed.

This commit fixes it by purging the list of connection message when
it cannot be cloned.

Fixes: 67879274 ("tipc: buffer overflow handling in listener socket")
Reported-by: Hoang Le <hoang.h.le@dektech.com.au>
Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Acked-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 61183b05

net/tipc/socket.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1447,8 +1447,10 @@ static int __tipc_sendmsg(struct socket sock, struct msghdr m, size_t dlen)
		rc = tipc_msg_build(hdr, m, 0, dlen, mtu, &pkts);
		if (unlikely(rc != dlen))
		return rc;
		if (unlikely(syn && !tipc_msg_skb_clone(&pkts, &sk->sk_write_queue)))
		if (unlikely(syn && !tipc_msg_skb_clone(&pkts, &sk->sk_write_queue))) {
		__skb_queue_purge(&pkts);
		return -ENOMEM;
		}

		trace_tipc_sk_sendmsg(sk, skb_peek(&pkts), TIPC_DUMP_SK_SNDQ, " ");
		rc = tipc_node_xmit(net, &pkts, dnode, tsk->portid);

Admin message