Commit 2fe5efb8 authored Apr 11, 2020 by Jules Irenge Committed by Kalle Valo Apr 15, 2020

brcmsmac: Add missing annotation for brcms_rfkill_set_hw_state()



Sparse reports a warning at brcms_rfkill_set_hw_state()

warning: context imbalance in brcms_rfkill_set_hw_state()
	- unexpected unlock
The root cause is the missing annotation at brcms_rfkill_set_hw_state()
Add the missing __must_hold(&wl->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200411001933.10072-5-jbi.octave@gmail.com

parent 1c0e3c73

drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1717,6 +1717,7 @@ int brcms_check_firmwares(struct brcms_info *wl)
		* precondition: perimeter lock has been acquired
		*/
		bool brcms_rfkill_set_hw_state(struct brcms_info *wl)
		__must_hold(&wl->lock)
		{
		bool blocked = brcms_c_check_radio_disabled(wl->wlc);

Admin message