Commit 2fd5fdca authored by Jason Yan's avatar Jason Yan Committed by Kalle Valo
Browse files

libertas: make lbs_init_mesh() void 



Fix the following coccicheck warning:

drivers/net/wireless/marvell/libertas/mesh.c:833:5-8: Unneeded variable:
"ret". Return "0" on line 874

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Reviewed-by: default avatarLubomir Rintel <lkundrak@v3.sk>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200410090942.27239-1-yanaijie@huawei.com
parent 80efb443

drivers/net/wireless/marvell/libertas/mesh.c

+1 −5
Original line number Diff line number Diff line
@@ -828,10 +828,8 @@ static void lbs_persist_config_remove(struct net_device *dev) 
 * Check mesh FW version and appropriately send the mesh start

 * command

 */

int lbs_init_mesh(struct lbs_private *priv)

void lbs_init_mesh(struct lbs_private *priv)

{

	int ret = 0;



	/* Determine mesh_fw_ver from fwrelease and fwcapinfo */

	/* 5.0.16p0 9.0.0.p0 is known to NOT support any mesh */

	/* 5.110.22 have mesh command with 0xa3 command id */
@@ -870,8 +868,6 @@ int lbs_init_mesh(struct lbs_private *priv) 


	/* Stop meshing until interface is brought up */

	lbs_mesh_config(priv, CMD_ACT_MESH_CONFIG_STOP, 1);



	return ret;

}



void lbs_start_mesh(struct lbs_private *priv)

drivers/net/wireless/marvell/libertas/mesh.h

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ 


struct net_device;



int lbs_init_mesh(struct lbs_private *priv);

void lbs_init_mesh(struct lbs_private *priv);

void lbs_start_mesh(struct lbs_private *priv);

int lbs_deinit_mesh(struct lbs_private *priv);

CRA Git | Maintained and supported by SUSTech CRA and CCSE