Commit 2fd14964 authored by Govindraj.R's avatar Govindraj.R Committed by Kevin Hilman
Browse files

ARM: OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos 



Omap_uart_can_sleep function blocks system wide low power state until
uart is active remove this func and add qos requests to prevent
MPU from transitioning.

Keep qos request to default value which will allow MPU to transition
and while uart baud rate is available calculate the latency value
from the baudrate and use the same to hold constraint while uart clocks
are enabled, and if uart is auto-idled the constraint is updated with
default constraint value allowing MPU to transition.

Qos requests are blocking notifier calls so put these requests to
work queue, also the driver uses irq_safe version of runtime API's
and callbacks can be called in interrupt disabled context.
So to avoid warn on slow path warning while using qos update
API's from runtime callbacks use the qos_work_queue.

During bootup the runtime_resume call backs might not be called and runtime
callback gets called only after uart is idled by setting the autosuspend
timeout. So qos_request from runtime resume callback might not activated during
boot if uart baudrate is calculated during bootup for console uart, so schedule
the qos_work queue once we calc_latency while configuring the uart port.

Flush and complete any pending qos jobs in work queue while suspending.

Signed-off-by: default avatarGovindraj.R <govindraj.raja@ti.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de> (for drivers/tty changes)
Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
parent 36fc2d15

arch/arm/mach-omap2/cpuidle34xx.c

+0 −6
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ 
#include <plat/irqs.h>

#include "powerdomain.h"

#include "clockdomain.h"

#include <plat/serial.h>



#include "pm.h"

#include "control.h"
@@ -245,11 +244,6 @@ static int omap3_enter_idle_bm(struct cpuidle_device *dev, 
	struct omap3_idle_statedata *cx;

	int ret;



	if (!omap3_can_sleep()) {

		new_state_idx = drv->safe_state_index;

		goto select_state;

	}



	/*

	 * Prevent idle completely if CAM is active.

	 * CAM does not have wakeup capability in OMAP3.

arch/arm/mach-omap2/pm24xx.c

+0 −2
Original line number Diff line number Diff line
@@ -222,8 +222,6 @@ static int omap2_can_sleep(void) 
{

	if (omap2_fclks_active())

		return 0;

	if (!omap_uart_can_sleep())

		return 0;

	if (osc_ck->usecount > 1)

		return 0;

	if (omap_dma_running())

arch/arm/mach-omap2/pm34xx.c

+0 −11
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ 
#include <plat/sram.h>

#include "clockdomain.h"

#include "powerdomain.h"

#include <plat/serial.h>

#include <plat/sdrc.h>

#include <plat/prcm.h>

#include <plat/gpmc.h>
@@ -456,21 +455,11 @@ void omap_sram_idle(void) 
	clkdm_allow_idle(mpu_pwrdm->pwrdm_clkdms[0]);

}



int omap3_can_sleep(void)

{

	if (!omap_uart_can_sleep())

		return 0;

	return 1;

}



static void omap3_pm_idle(void)

{

	local_irq_disable();

	local_fiq_disable();



	if (!omap3_can_sleep())

		goto out;



	if (omap_irq_pending() || need_resched())

		goto out;

arch/arm/mach-omap2/serial.c

+0 −22
Original line number Diff line number Diff line
@@ -82,28 +82,6 @@ static struct omap_uart_port_info omap_serial_default_info[] __initdata = { 
};



#ifdef CONFIG_PM



int omap_uart_can_sleep(void)

{

	struct omap_uart_state *uart;

	int can_sleep = 1;



	list_for_each_entry(uart, &uart_list, node) {

		if (!uart->clocked)

			continue;



		if (!uart->can_sleep) {

			can_sleep = 0;

			continue;

		}



		/* This UART can now safely sleep. */

		omap_uart_allow_sleep(uart);

	}



	return can_sleep;

}



static void omap_uart_enable_wakeup(struct platform_device *pdev, bool enable)

{

	struct omap_device *od = to_omap_device(pdev);

arch/arm/plat-omap/include/plat/omap-serial.h

+6 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 


#include <linux/serial_core.h>

#include <linux/platform_device.h>

#include <linux/pm_qos.h>



#include <plat/mux.h>
@@ -130,6 +131,11 @@ struct uart_omap_port { 
	u32			context_loss_cnt;

	u32			errata;

	u8			wakeups_enabled;



	struct pm_qos_request	pm_qos_request;

	u32			latency;

	u32			calc_latency;

	struct work_struct	qos_work;

};



#endif /* __OMAP_SERIAL_H__ */

CRA Git | Maintained and supported by SUSTech CRA and CCSE