Commit 2fc6d4be authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: dwc3: gadget: fix ISOC TRB type on unaligned transfers 



When chaining ISOC TRBs together, only the first ISOC TRB should be of
type ISOC_FIRST, all others should be of type ISOC. This patch fixes
that.

Fixes: c6267a51 ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: <stable@vger.kernel.org> # v4.11+
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent a9c85903

drivers/usb/dwc3/gadget.c

+3 −3
Original line number Diff line number Diff line
@@ -1081,7 +1081,7 @@ static void dwc3_prepare_one_trb_sg(struct dwc3_ep *dep, 
			/* Now prepare one extra TRB to align transfer size */

			trb = &dep->trb_pool[dep->trb_enqueue];

			__dwc3_prepare_one_trb(dep, trb, dwc->bounce_addr,

					maxp - rem, false, 0,

					maxp - rem, false, 1,

					req->request.stream_id,

					req->request.short_not_ok,

					req->request.no_interrupt);
@@ -1125,7 +1125,7 @@ static void dwc3_prepare_one_trb_linear(struct dwc3_ep *dep, 
		/* Now prepare one extra TRB to align transfer size */

		trb = &dep->trb_pool[dep->trb_enqueue];

		__dwc3_prepare_one_trb(dep, trb, dwc->bounce_addr, maxp - rem,

				false, 0, req->request.stream_id,

				false, 1, req->request.stream_id,

				req->request.short_not_ok,

				req->request.no_interrupt);

	} else if (req->request.zero && req->request.length &&
@@ -1141,7 +1141,7 @@ static void dwc3_prepare_one_trb_linear(struct dwc3_ep *dep, 
		/* Now prepare one extra TRB to handle ZLP */

		trb = &dep->trb_pool[dep->trb_enqueue];

		__dwc3_prepare_one_trb(dep, trb, dwc->bounce_addr, 0,

				false, 0, req->request.stream_id,

				false, 1, req->request.stream_id,

				req->request.short_not_ok,

				req->request.no_interrupt);

	} else {

CRA Git | Maintained and supported by SUSTech CRA and CCSE