ASoC: Intel: bytcr_rt5640: align quirk override handling (2fb2a19a) · Commits · 戴 / test

As discussed on alsa-devel, a zero value is useful to get rid of all quirks. Set default to -1 and align types as done in other machine drivers. Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by:

Hans de Goede <hdegoede@redhat.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/intel/boards/bytcr_rt5640.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -98,8 +98,8 @@ struct byt_rt5640_private {
		static bool is_bytcr;

		static unsigned long byt_rt5640_quirk = BYT_RT5640_MCLK_EN;
		static unsigned int quirk_override;
		module_param_named(quirk, quirk_override, uint, 0444);
		static int quirk_override = -1;
		module_param_named(quirk, quirk_override, int, 0444);
		MODULE_PARM_DESC(quirk, "Board-specific quirk override");

		static void log_quirks(struct device *dev)
		@@ -1254,7 +1254,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
		dmi_id = dmi_first_match(byt_rt5640_quirk_table);
		if (dmi_id)
		byt_rt5640_quirk = (unsigned long)dmi_id->driver_data;
		if (quirk_override) {
		if (quirk_override != -1) {
		dev_info(&pdev->dev, "Overriding quirk 0x%x => 0x%x\n",
		(unsigned int)byt_rt5640_quirk, quirk_override);
		byt_rt5640_quirk = quirk_override;

Admin message