dmaengine: k3-udma: convert tasklets to use new tasklet_setup() API (2fa9bc98) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Allen Pais <allen.lkml@gmail.com> Acked-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Link: https://lore.kernel.org/r/20200831103542.305571-36-allen.lkml@gmail.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/ti/k3-udma.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -2909,9 +2909,9 @@ static void udma_desc_pre_callback(struct virt_dma_chan *vc,
		* This tasklet handles the completion of a DMA descriptor by
		* calling its callback and freeing it.
		*/
		static void udma_vchan_complete(unsigned long arg)
		static void udma_vchan_complete(struct tasklet_struct *t)
		{
		struct virt_dma_chan vc = (struct virt_dma_chan )arg;
		struct virt_dma_chan *vc = from_tasklet(vc, t, task);
		struct virt_dma_desc vd, _vd;
		struct dmaengine_desc_callback cb;
		LIST_HEAD(head);
		@@ -3667,8 +3667,7 @@ static int udma_probe(struct platform_device *pdev)

		vchan_init(&uc->vc, &ud->ddev);
		/* Use custom vchan completion handling */
		tasklet_init(&uc->vc.task, udma_vchan_complete,
		(unsigned long)&uc->vc);
		tasklet_setup(&uc->vc.task, udma_vchan_complete);
		init_completion(&uc->teardown_completed);
		INIT_DELAYED_WORK(&uc->tx_drain.work, udma_check_tx_completion);
		}

Admin message