Commit 2fa76062 authored Apr 29, 2013 by Sachin Kamat Committed by Linus Torvalds Apr 29, 2013

drivers/rtc/rtc-max8907.c: remove redundant code



Remove unnecessary goto statements to simplify the code.
devm_request_threaded_irq returns 0 upon success, hence explicit return 0
is not necessary.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Chiwoong Byun <woong.byun@samsung.com>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: Laxman dewangan <ldewangan@nvidia.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ad819039

drivers/rtc/rtc-max8907.c

+3 −10

Original line number	Diff line number	Diff line
		@@ -200,23 +200,16 @@ static int max8907_rtc_probe(struct platform_device *pdev)

		rtc->irq = regmap_irq_get_virq(max8907->irqc_rtc,
		MAX8907_IRQ_RTC_ALARM0);
		if (rtc->irq < 0) {
		ret = rtc->irq;
		goto err_unregister;
		}
		if (rtc->irq < 0)
		return rtc->irq;

		ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
		max8907_irq_handler,
		IRQF_ONESHOT, "max8907-alarm0", rtc);
		if (ret < 0) {
		if (ret < 0)
		dev_err(&pdev->dev, "Failed to request IRQ%d: %d\n",
		rtc->irq, ret);
		goto err_unregister;
		}

		return 0;

		err_unregister:
		return ret;
		}

Admin message