Commit 2fa299a9 authored Feb 22, 2017 by Jiri Kosina

HID: rmi: fallback to generic/multitouch if hid-rmi is not built



Commit 279967a6 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi")
unconditionally switches over handling of all Synaptics touchpads to hid-rmi
(to make use of extended features of the HW); in case CONFIG_HID_RMI is
disabled though this renders the touchpad unusable, as the

	HID_DEVICE(HID_BUS_ANY, HID_GROUP_RMI, HID_ANY_ID, HID_ANY_ID)

match doesn't exist and generic/multitouch doesn't bind to it either (due
to hid group mismatch).

Fix this by switching over to hid-rmi only if it has been actually built.

Fixes: 279967a6 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: Andrew Duggan <aduggan@synaptics.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 27a67e0f

drivers/hid/hid-core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -827,6 +827,7 @@ static int hid_scan_report(struct hid_device *hid)
		* hid-rmi should take care of them,
		* not hid-generic
		*/
		if (IS_ENABLED(CONFIG_HID_RMI))
		hid->group = HID_GROUP_RMI;
		break;
		}

Admin message