iio: adc: xilinx: Move request_irq before enabling interrupts (2fa03b92) · Commits · 戴 / test

Enabling the Interrupts before registering the irq handler is a bad idea. This patch corrects the same for XADC driver. Signed-off-by:

drivers/iio/adc/xilinx-xadc-core.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1226,15 +1226,15 @@ static int xadc_probe(struct platform_device *pdev)
		if (ret)
		goto err_free_samplerate_trigger;

		ret = xadc->ops->setup(pdev, indio_dev, xadc->irq);
		if (ret)
		goto err_clk_disable_unprepare;

		ret = request_irq(xadc->irq, xadc->ops->interrupt_handler, 0,
		dev_name(&pdev->dev), indio_dev);
		if (ret)
		goto err_clk_disable_unprepare;

		ret = xadc->ops->setup(pdev, indio_dev, xadc->irq);
		if (ret)
		goto err_free_irq;

		for (i = 0; i < 16; i++)
		xadc_read_adc_reg(xadc, XADC_REG_THRESHOLD(i),
		&xadc->threshold[i]);