Commit 2f8ea97a authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

hwmon: (w83627hf) Drop reset module parameter 



Drop the reset parameter of the w83627hf driver. It seems it wasn't
that useful. It was dropped from the Linux 2.4 version of this driver
back in July 2004.

The only users who have reported that they were still using this
parameter, needed it to switch the chip from automatic fan speed
control back to manual mode. Now that the driver creates pwmN_enable
sysfs files, users will be able to use these files instead, which is
way less agressive.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarDominik Geyer <dominik.geyer@gmx.de>
parent a95a5ed8

Documentation/hwmon/w83627hf

+0 −4
Original line number Diff line number Diff line
@@ -40,10 +40,6 @@ Module Parameters 
  (default is 1)

  Use 'init=0' to bypass initializing the chip.

  Try this if your computer crashes when you load the module.

* reset: int

  (default is 0)

  The driver used to reset the chip on load, but does no more. Use

  'reset=1' to restore the old behavior. Report if you need to do this.



Description

-----------

drivers/hwmon/w83627hf.c

+0 −27
Original line number Diff line number Diff line
@@ -67,10 +67,6 @@ module_param(force_i2c, byte, 0); 
MODULE_PARM_DESC(force_i2c,

		 "Initialize the i2c address of the sensors");



static int reset;

module_param(reset, bool, 0);

MODULE_PARM_DESC(reset, "Set to one to reset chip on load");



static int init = 1;

module_param(init, bool, 0);

MODULE_PARM_DESC(init, "Set to zero to bypass chip initialization");
@@ -1600,29 +1596,6 @@ static void __devinit w83627hf_init_device(struct platform_device *pdev) 
	enum chips type = data->type;

	u8 tmp;



	if (reset) {

		/* Resetting the chip has been the default for a long time,

		   but repeatedly caused problems (fans going to full

		   speed...) so it is now optional. It might even go away if

		   nobody reports it as being useful, as I see very little

		   reason why this would be needed at all. */

		dev_info(&pdev->dev, "If reset=1 solved a problem you were "

			 "having, please report!\n");



		/* save this register */

		i = w83627hf_read_value(data, W83781D_REG_BEEP_CONFIG);

		/* Reset all except Watchdog values and last conversion values

		   This sets fan-divs to 2, among others */

		w83627hf_write_value(data, W83781D_REG_CONFIG, 0x80);

		/* Restore the register and disable power-on abnormal beep.

		   This saves FAN 1/2/3 input/output values set by BIOS. */

		w83627hf_write_value(data, W83781D_REG_BEEP_CONFIG, i | 0x80);

		/* Disable master beep-enable (reset turns it on).

		   Individual beeps should be reset to off but for some reason

		   disabling this bit helps some people not get beeped */

		w83627hf_write_value(data, W83781D_REG_BEEP_INTS2, 0);

	}



	/* Minimize conflicts with other winbond i2c-only clients...  */

	/* disable i2c subclients... how to disable main i2c client?? */

	/* force i2c address to relatively uncommon address */

CRA Git | Maintained and supported by SUSTech CRA and CCSE