Commit 2f6c498e authored Dec 07, 2017 by Neal Cardwell Committed by David S. Miller Dec 08, 2017

tcp_bbr: reset full pipe detection on loss recovery undo



Fix BBR so that upon notification of a loss recovery undo BBR resets
the full pipe detection (STARTUP exit) state machine.

Under high reordering, reordering events can be interpreted as loss.
If the reordering and spurious loss estimates are high enough, this
could previously cause BBR to spuriously estimate that the pipe is
full.

Since spurious loss recovery means that our overall sending will have
slowed down spuriously, this commit gives a flow more time to probe
robustly for bandwidth and decide the pipe is really full.

Signed-off-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Yuchung Cheng <ycheng@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c589e69b

net/ipv4/tcp_bbr.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -874,6 +874,10 @@ static u32 bbr_sndbuf_expand(struct sock *sk)
		*/
		static u32 bbr_undo_cwnd(struct sock *sk)
		{
		struct bbr *bbr = inet_csk_ca(sk);

		bbr->full_bw = 0; /* spurious slow-down; reset full pipe detection */
		bbr->full_bw_cnt = 0;
		return tcp_sk(sk)->snd_cwnd;
		}

Admin message