Commit 2f578aaf authored Jun 09, 2019 by Minwoo Im Committed by Jens Axboe Jun 20, 2019

block: move tag field position in struct request

__data_len and __sector are internal fields which should not be accessed
directly in driver-level like the comment above it. But, tag field can
be accessed by driver level directly so that we need to make the comment
right by moving it to some other place.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 2af47c10

include/linux/blkdev.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -137,11 +137,11 @@ struct request {
		unsigned int cmd_flags; /* op and common flags */
		req_flags_t rq_flags;

		int tag;
		int internal_tag;

		/* the following two fields are internal, NEVER access directly */
		unsigned int __data_len; /* total data len */
		int tag;
		sector_t __sector; /* sector cursor */

		struct bio *bio;

Admin message